Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed variable scope of tmpfd that causing compilation error in main() #55

Merged
merged 1 commit into from
Dec 6, 2017

Conversation

cry0this
Copy link
Contributor

@cry0this cry0this commented Nov 2, 2017

Last moving of tmpfd is leading to compilation error because exiting of current scope. I moved declaration of tmpfd up to previous string.

@cry0this cry0this changed the title Fixing variable scope of tmpfd that causing compilation error in main() Fixed variable scope of tmpfd that causing compilation error in main() Nov 2, 2017
@ghost
Copy link

ghost commented Nov 30, 2017

Strange. GCC compiles for me without errors. What compiler are you using?

I see why you would move it up though... I'm a little surprised it compiled on my machine.

@travisbell
Copy link

I also had this error, this patch fixes it. This is on OS X.

@ghost
Copy link

ghost commented Dec 5, 2017

Tried it on a few different machines with GCC, no change in behavior, no compilation errors.

But yeah, the variable ceases to exist after the if-statement. Compiling this patch works properly. I'll investigate this a little more as to why GCC is compiling without errors.

Oh man and that error was my mistake too, fml.

@tjko tjko merged commit 2669699 into tjko:master Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants