Skip Spring version 2.1.1 #389
Conversation
|
I occurred to me we saw some recent failures in suspenders that are probably similar to this. For some reason commands that used to run in a test app directory started getting run in the top-level suspenders directory. I think that is what is happening here: the test is in factory_bot_rails/tmp/aruba/test_app/test, but for some reason something somewhere is looking for it in factory_bot_rails/test. I don't think this is a good solution, but if we change I would love to know what library changed this behavior for us, but not sure how to find out. We were having some rake issues, so maybe something in there somewhere? |
|
Figured it out. It was introduced in spring 2.1.1 (rails/spring#621). That change was reverted in rails/spring#629, but hasn't been released yet. So I think the solution here is to avoid the broken version of spring. I think we can do that by adding a "!= 2.1.1" constraint to the Gemfile, updating the appraisals, and adding cc @garciadanny and @mike-burns in case this helps you with the suspenders tests. Or if you wait long enough they might fix themselves when a new version of spring comes out. |
features/support/rails_template
Outdated
| @@ -1,3 +1,4 @@ | |||
| if Rails.gem_version < Gem::Version.new('6') | |||
| gsub_file "Gemfile", /^gem 'sqlite3'$/, 'gem "sqlite3", "~> 1.3.6"' | |||
| gsub_file "Gemfile", /^ gem 'spring'$/, ' gem "spring", "!= 2.1.1"' | |||
There was a problem hiding this comment.
I think we want this outside the if Rails.gem_version < Gem::Version.new('6') check, since it is failing in every version.
There was a problem hiding this comment.
Good call! Updated in c301ff9.
I still see one local failing reloading.feature scenario that times out. Is it green for you? Let's see what CI has to say.
There was a problem hiding this comment.
Although the rails 6 tests passed anyway so 🤷🏻♂️
There was a problem hiding this comment.
Pushed up an additional commit to fix the standard style violation.
There was a problem hiding this comment.
Thank you! We have a green test suite, should we squash & merge?
There was a problem hiding this comment.
🎉 Yippee! I'll leave it to you.
composerinteralia
force-pushed
the
update-tests
branch
from
780be01
to
b067e96
Compare
|
BTW, this is the Travis announcement I was thinking of, specifically the part about OSS. |
Changes introduced in spring 2.1.1 (rails/spring#621) are breaking some tests. That change was reverted in rails/spring#629, but hasn't been released yet. Until #629 is released, this PR skips Spring version 2.1.1. Co-authored-by: Daniel J. Colson <daniel.colson@hey.com>
We are using the latest standard on CI. This bumps the version in the dev Gemfile to match, and fixes one violation.
entcheva
force-pushed
the
update-tests
branch
from
b067e96
to
161d634
Compare
entcheva
changed the title
|
@entcheva it seems like we may want to migrate from Travis to Circle at some point. |
|
@composerinteralia Nice! I especially appreciate the performance comparison to Github Actions. This is a helpful breakdown, thank you! |
Changes introduced in Spring 2.1.1 (rails/spring#621) are breaking some tests. That change was reverted in rails/spring#629 but hasn't been released yet. Until rails/spring#629 is released, this PR skips Spring version 2.1.1.
Co-authored-by: Daniel J. Colson daniel.colson@hey.com