Reuse socket connection when sending metrics #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great catch @vgarvardt! Everything seems to work and tests pass so I'm good with this. Clean abstraction to a function as well. One tiny thing regarding the comments, could you possibly update to stick with the current format of comments that the rest of the files have for consistency? Thanks |
|
@marcqualie sorry about that - applied autoformatting to the file with my default code style. Should be fixed now. |
|
Thanks for the great contribution @vgarvardt! |
|
@marcqualie what is the release cycle of the library? Is there estimated date when the patch will be available in the release version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use your library for
statsdbackend in ourhellofresh/stats-phplibrary. Recently we added quite a lot of new metrics to one of our legacy monolith project to profile some bottlenecks and found that although metrics are sent via UDP we got significant performance degradation. During the investigation we found thatstatsdopens new socket connection for every metric being sent, that is quite expensive operation.I fixed the issue in our library - hellofresh/stats-php#3 (we tested it before merging), but I think it would be useful to have this feature/fix in the base library.