Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fave104 default layout #1369

Merged
merged 2 commits into from
Aug 18, 2022
Merged

Update fave104 default layout #1369

merged 2 commits into from
Aug 18, 2022

Conversation

duilchoi
Copy link
Contributor

@duilchoi duilchoi commented Aug 17, 2022

Description

Update fave104 default layout

QMK Pull Request

qmk/qmk_firmware#17909

Checklist

  • The VIA support for this keyboard is in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@yiancar
Copy link
Collaborator

yiancar commented Aug 18, 2022

I presume this is the PR you want merged and not this: #1364 ?

Please close the one that is not needed

@duilchoi
Copy link
Contributor Author

thanks !

@yiancar
Copy link
Collaborator

yiancar commented Aug 18, 2022

Cheers thanks:D

@yiancar yiancar merged commit 9babfc6 into the-via:master Aug 18, 2022
mattchan pushed a commit to mattchan/keyboards that referenced this pull request Aug 31, 2022
* add fave104 json file

* Update Fave104.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants