Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for vitamins included #105

Merged
merged 2 commits into from
Jun 21, 2020
Merged

Conversation

Duckle29
Copy link
Contributor

Description

Added support for both revisions of the vitamins included. I use an actual VID:PID from pid.codes

QMK Pull Request

qmk/qmk_firmware#8876

Checklist

  • The QMK source code follows the guide here: https://caniusevia.com/docs/configuring_qmk
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@wilba
Copy link
Contributor

wilba commented Apr 28, 2020

The mod/accent colors in this are not consistent.

image

@wilba wilba added pending QMK merge Waiting for merge into QMK master and removed pending QMK merge Waiting for merge into QMK master labels Apr 28, 2020
Made all outer keys modifier colored
@Duckle29
Copy link
Contributor Author

Hi, thanks for taking a look. I may have misunderstood the ideas with the coloring. I've colored it this way since the ones colored #AAAAAA are modifiers in the default layout. I've included raise and lower function keys in this "modifier" group (3,4 and 7,1) however 7,2-7,5 are arrow keys.

Since VIA is for dynamic key assignment, I can see why this may not make much sense, and the example of accent keys being "arrowkeys" makes more sense if they're clustered as such.

I've made the edge keys all modifier colored :)

@wilba wilba merged commit e59e1ef into the-via:master Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants