Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[discord] RPC Fix #888

Merged
merged 3 commits into from
Nov 20, 2022
Merged

[discord] RPC Fix #888

merged 3 commits into from
Nov 20, 2022

Conversation

Zo-Bro-23
Copy link
Contributor

Update to new client ID so that the Discord Plugin works properly
Thanks to @zoeeechu for the fix!

Copy link
Owner

@th-ch th-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, but for context, why is it needed to change it? (also Application ID registered by @xn-oah is it still the case?)

@Zo-Bro-23
Copy link
Contributor Author

The application ID registered by @xn-oah doesn't seem to work anymore, so this is an application ID registered by @zoeeechu. It doesn't matter who registers the application ID as long as it's a valid ID, so it's fine either way, but you can edit my commit with your own application ID if you want more control over the Discord plugin (picture, application name, etc). Just head over to the Discord Developer Portal and register an application (and paste the client ID here).

@Zo-Bro-23
Copy link
Contributor Author

On second thoughts, I've added a commit where I've updated the application ID to an application that I created, so that the image and name syntax reflect the convention used for the application (@zoeeechu had lowercase with no image). I've also updated the comments to reflect this change. Let me know if anything else needs to be changed!

@th-ch th-ch merged commit 3605e32 into th-ch:master Nov 20, 2022
@Araxeus Araxeus changed the title Discord Plugin RPC Fix [Discord] RPC Fix Mar 15, 2023
@Araxeus Araxeus changed the title [Discord] RPC Fix [discord] RPC Fix Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants