Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ; instead of space for play/pause. #745

Merged
merged 1 commit into from
Jun 25, 2022
Merged

Use ; instead of space for play/pause. #745

merged 1 commit into from
Jun 25, 2022

Conversation

lukaszg84
Copy link

@lukaszg84 lukaszg84 commented Jun 10, 2022

fix #741

@Araxeus
Copy link
Collaborator

Araxeus commented Jun 10, 2022

FYI this pr can be automatically linked to the issue and close it when its merged

https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

(just write fix #741)

@lukaszg84
Copy link
Author

Seems that after your comment it is linked already.

How long does it take between the fix and deb package being released?

@Araxeus
Copy link
Collaborator

Araxeus commented Jun 10, 2022

Seems that after your comment it is linked already.

Nope it's still not linked, you need to edit your original post and then it will link it

How long does it take between the fix and deb package being released?

Well it requires multiple steps:

  1. The PR gets merged (depends on @th-ch)
  2. New app version is released (depends on @th-ch)
    deb files should be included in the release

if you are talking about arch linux then you need to wait for a 3rd step: the aur maintainer needs to upload the new version

@lukaszg84 lukaszg84 changed the title Use ; instead of space for play/pause. Use ; instead of space for play/pause. fix #741 Jun 10, 2022
@lukaszg84 lukaszg84 changed the title Use ; instead of space for play/pause. fix #741 Use ; instead of space for play/pause. Jun 10, 2022
Copy link
Owner

@th-ch th-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix!

@th-ch th-ch merged commit 8ec965a into th-ch:master Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Play/pause dbus control does not work until play button is clicked
3 participants