Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint #701

Merged
merged 3 commits into from
May 1, 2022
Merged

lint #701

merged 3 commits into from
May 1, 2022

Conversation

Araxeus
Copy link
Collaborator

@Araxeus Araxeus commented Apr 22, 2022

see commit names

th-ch
th-ch approved these changes May 1, 2022
View reviewed changes
Copy link
Owner

@th-ch th-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! The linter could also be added to CI to prevent ensure all new code is linted

@th-ch th-ch merged commit 3394d64 into th-ch:master May 1, 2022
@Araxeus
Copy link
Collaborator Author

Araxeus commented May 1, 2022

The lint was from codefactor

but I do propose setting up those 2 actions:
https://github.com/th-ch/youtube-music/actions/new
image

@Araxeus
Copy link
Collaborator Author

Araxeus commented May 24, 2022

@th-ch did you see my comment above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@th-ch th-ch th-ch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Araxeus @th-ch