Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add album title to largeImage and change paused icon #587

Merged
merged 2 commits into from
Feb 13, 2022
Merged

Add album title to largeImage and change paused icon #587

merged 2 commits into from
Feb 13, 2022

Conversation

im-noahh
Copy link
Contributor

paused

@Araxeus
Copy link
Collaborator

Araxeus commented Jan 30, 2022 •
edited
Loading

album hover text will only correctly display after #588 is merged

Like so:
image
(Fortitude is the album name and is displayed on hover)

th-ch
th-ch approved these changes Feb 13, 2022
View reviewed changes
Copy link
Owner

@th-ch th-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@th-ch th-ch merged commit 7f0d623 into th-ch:master Feb 13, 2022
@Araxeus
Copy link
Collaborator

Araxeus commented Feb 13, 2022 •
edited
Loading

@xn-oah this clientId seems to not work anymore..
image

switching to the old clientId registered by semvis instantly works

@th-ch
Copy link
Owner

th-ch commented Feb 13, 2022

@xn-oah is your app still correctly registered, or should we switch back to the previous client ID?

@im-noahh
Copy link
Contributor Author

im-noahh commented Feb 13, 2022 •
edited
Loading

@xn-oah is your app still correctly registered, or should we switch back to the previous client ID?

Fix in #602, really sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Araxeus Araxeus Araxeus left review comments

@th-ch th-ch th-ch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@im-noahh @Araxeus @th-ch