Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix precise-volume options sync #525

Merged
merged 1 commit into from
Dec 30, 2021
Merged

fix precise-volume options sync #525

merged 1 commit into from
Dec 30, 2021

Conversation

Araxeus
Copy link
Collaborator

@Araxeus Araxeus commented Dec 24, 2021 •
edited
Loading

As title says, this PR mainly aims to fix an issue with precise-volume options sync between main and renderer
(for example changing keybinds (menu.js) and then changing the volume (front.js) would reset the keybind)

those 2 fixes below are also included:

  • fixed an issue where the custom volume steps was interpreted as a string instead of a number
  • slightly reduced the "cooldown" for saving the volume

th-ch
th-ch approved these changes Dec 30, 2021
View reviewed changes
Copy link
Owner

@th-ch th-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix! ✅

@th-ch th-ch merged commit bd520c7 into th-ch:master Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@th-ch th-ch th-ch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Araxeus @th-ch