Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blur plugin tweaks and integration with in-app-menu #451

Merged
merged 3 commits into from
Nov 1, 2021

Conversation

Araxeus
Copy link
Collaborator

@Araxeus Araxeus commented Oct 24, 2021

  • Adds blur to header (in the screenshot below its the playlists|albums|songs|artists|subscriptions) and recently added div)
    image
    this was done for consistency because this header sticks to the navbar when scrolling the page down.

(only problem is that you can kinda see the separating line between both blurred elements which can be a bit weird but its better than the header being black when the top bar is blurred)

  • Makes in-app-menu compatible with this plugin with some small adjustments to the css
  • Dynamically adjust navbar position to compensate for the scrollbar which appears on all pages except the playerpage (it was weird when there was a 15px gap in the navbar when inside a colored playerpage)

this follows up pr #442 by @cdaydreamer

@Araxeus Araxeus changed the title Add blur to (library)header + make in-app-menu compatible Blur plugin tweaks Oct 24, 2021
@Araxeus Araxeus changed the title Blur plugin tweaks Blur plugin tweaks and integration with in-app-menu Oct 25, 2021
Copy link
Owner

@th-ch th-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the improvement! ✅

@th-ch th-ch merged commit 5256ffc into th-ch:master Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants