Dependencies update #231
Merged
Dependencies update #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(electron 11.4.2 fixed the bug that required that)
th-ch
approved these changes
Apr 29, 2021
|
|
||
| module.exports.getFolder = (customFolder) => customFolder || downloadsFolder(); | ||
| module.exports.getFolder = (customFolder) => customFolder || app.getPath("downloads"); |
There was a problem hiding this comment.
The app module from electron is only available in the main process, not the renderer one, so it breaks the downloader - a fix for that is to use (electron.app || electron.remote.app).getPath("downloads")
There was a problem hiding this comment.
Woups sorry I missed that, good catch 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
downloads-folderdependency - use insteadapp.getPath("downloads")Updated most of the dependencies, notable important fixes:
Electron 11.4.2 has fixed
win.hidebreaking thumbar (because of my feedback 😋 )🔽
Updated
taskbar-mediacontrolaccordingly - it no longer overrideswin.hide()+win.show()+set taskbar on
win.show()if songInfo is validYoutubeNonStop v0.9.0 probably fixed a bug with
auto-confirm-when-pausednot allowing pausing through external buttons [Tray, Taskbar, Notifications]