This repository has been archived by the owner on Jul 1, 2023. It is now read-only.
TensorFlow: silence a warning from the Swift compiler #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The trailing closure application to the function can be confused with the function body as per the diagnostic emitted by the swift compiler. With the recent changes to the application of trailing closures and support for multiple trailing closures, the syntax is accepted but is confusing. Convert from the trailing closure to an inline closure to make this explicit.
pschuh
approved these changes
Dec 15, 2020
dan-zheng
approved these changes
Dec 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trailing closure application to the function can be confused with
the function body as per the diagnostic emitted by the swift compiler.
With the recent changes to the application of trailing closures and
support for multiple trailing closures, the syntax is accepted but is
confusing. Convert from the trailing closure to an inline closure to
make this explicit.