Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small tweaks to Holocene components for self serve signup #1866

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

rossedfort
Copy link
Contributor

Description & motivation 💭

  • Support label slot in checkbox. This is so that links (or any other markup) can be rendered in the checkbox label
Screenshot 2024-02-14 at 10 32 15 AM
  • Add close event to combobox. This is so that we have an event to catch when the menu is closed without the user having selected a value (i.e. they open the list of options by focusing the combobox, but then click away). This is useful to add inline errors to the combobox when a value is required.
  • Only dispatch close even from <MenuContainer /> if menu is open

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

add close event to combobox
only dispatch close even from menucontainer if menu is open
Copy link

vercel bot commented Feb 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview Feb 14, 2024 5:35pm

@rossedfort rossedfort merged commit f060a68 into main Feb 14, 2024
11 checks passed
@rossedfort rossedfort deleted the ssu-holocene-updates branch February 14, 2024 18:47
{label}
</span>
<slot name="label">
<span class="label" class:sr-only={labelHidden}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could a checkbox potentially have both a label slot and a label prop? Wondering if we want to make this a conditional so that there's no potential for both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants