DT-1654 - add scheduled by id and scheduled start time to workflow table columns #1785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rossedfort
requested review from
laurakwhit and
Alex-Tideman
and removed request for
stevekinney and
Alex-Tideman
Alex-Tideman
reviewed
Jan 4, 2024
Comment on lines
+106
to
+111
| {workflow.searchAttributes?.indexedFields?.TemporalScheduledById ?? ''} | ||
| {:else if label === 'Scheduled Start Time'} | ||
| {@const content = | ||
| workflow.searchAttributes?.indexedFields?.TemporalScheduledStartTime} | ||
| {content && typeof content === 'string' | ||
| ? formatDate(content, $timeFormat, { relative: $relativeTime }) |
There was a problem hiding this comment.
Are these decoded already? I know they don't need to go to the codec server but they are payloads so need to be base64 decoded
There was a problem hiding this comment.
Yep, they are decoded when we get them back from the server: https://github.com/temporalio/ui/blob/main/src/lib/models/workflow-execution.ts#L39
Alex-Tideman
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Adds the
TemporalScheduledByIdandTemporalScheduledStartTimeinternal search attributes to the list of available columns for the workflows summary table. Note - we should eventually refactor this table to read the internal and custom search attributes from the API and generate a list of available columns.Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?