DT-1421 - improve workflow reset form #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and add more descriptive label default the checkbox to checked, which applies signals after the reset point also add description to RadioGroup
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Alex-Tideman
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Create a workflow, then signal it. Reset that workflow with the checkbox "checked" and ensure the signal is reapplied on the new workflow. Reset that workflow with the checkbox "unchecked" and ensure the signal is not reapplied on the new workflow.
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?