Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DT-1016 - display custom search attributes in UI #1414

Merged
merged 45 commits into from
Jun 14, 2023

Conversation

rossedfort
Copy link
Contributor

@rossedfort rossedfort commented Jun 6, 2023

Description & motivation 💭

Previously the UI was using workflowservice/GetSearchAttributes to fetch Search Attributes at the cluster level. By adding and consuming the operatorservice/ListSearchAttributes API, we are able to fetch Search Attributes on a per-namespace level. This PR has no style or design changes, just rewires our service and store(s) to use the new RPC method and does some more test cleanup.

Other changes of note:

  • update @temporalio/api submodule to v1.21.0
  • update other ui-server go dependencies
  • update tests/integration to use only mocks

Screenshots (if applicable) 📸

N/a

Design Considerations 🎨

N/a

Testing 🧪

How was this tested 👻

Covered by manual testing and existing e2e/unit tests. No new tests were added.

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

  • go to /namespaces/{namespace} and ensure all system search attributes are displayed
  • add a search attribute (can be done with temporal operator search-attribute create --namespace {namespace} --name SearchAttrName --type SearchAttrType if running against temporal cli's dev server)
  • refresh /namespaces/{namespace} to ensure new custom search attribute is displayed
  • also go to /namespaces/{namespace}/workflows and open the workflows summary table configuration panel to ensure all search attributes are displayed.

Checklists

Draft Checklist

N/a

Merge Checklist

N/a

Issue(s) closed

closes #1274

Docs

Any docs updates needed?

- consume new search attributes API
- adjust search attributes stores to reflect new API response
@vercel
Copy link

vercel bot commented Jun 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
holocene ⬜️ Ignored (Inspect) Visit Preview Jun 14, 2023 4:40pm

@rossedfort rossedfort changed the title DT-610 - display custom search attributes in UI DT-1016 - display custom search attributes in UI Jun 6, 2023
@rossedfort rossedfort mentioned this pull request Jun 14, 2023
3 tasks
@rossedfort rossedfort merged commit 04f697d into main Jun 14, 2023
@rossedfort rossedfort deleted the DT-1016-fix-custom-search-attributes branch June 14, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Custom search attributes not showing up in UI
2 participants