-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DT-1016 - display custom search attributes in UI #1414
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- consume new search attributes API - adjust search attributes stores to reflect new API response
rossedfort
requested review from
stevekinney,
Alex-Tideman and
a team
as code owners
June 6, 2023 17:22
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
rossedfort
changed the title
DT-610 - display custom search attributes in UI
DT-1016 - display custom search attributes in UI
Jun 6, 2023
Alex-Tideman
approved these changes
Jun 14, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Previously the UI was using
workflowservice/GetSearchAttributes
to fetch Search Attributes at the cluster level. By adding and consuming theoperatorservice/ListSearchAttributes
API, we are able to fetch Search Attributes on a per-namespace level. This PR has no style or design changes, just rewires our service and store(s) to use the new RPC method and does some more test cleanup.Other changes of note:
@temporalio/api
submodule tov1.21.0
tests/integration
to use only mocksScreenshots (if applicable) 📸
N/a
Design Considerations 🎨
N/a
Testing 🧪
How was this tested 👻
Covered by manual testing and existing e2e/unit tests. No new tests were added.
Steps for others to test: 🚶🏽♂️🚶🏽♀️
/namespaces/{namespace}
and ensure all system search attributes are displayedtemporal operator search-attribute create --namespace {namespace} --name SearchAttrName --type SearchAttrType
if running against temporal cli's dev server)/namespaces/{namespace}
to ensure new custom search attribute is displayed/namespaces/{namespace}/workflows
and open the workflows summary table configuration panel to ensure all search attributes are displayed.Checklists
Draft Checklist
N/a
Merge Checklist
N/a
Issue(s) closed
closes #1274
Docs
Any docs updates needed?