Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import ui-server. #1112

Merged
merged 41 commits into from
Feb 14, 2023
Merged

Import ui-server. #1112

merged 41 commits into from
Feb 14, 2023

Conversation

robholland
Copy link
Contributor

@robholland robholland commented Feb 3, 2023

What was changed

Merged ui-server code into the ui repo, including some refactorings.

Why?

To make it easier for contributors and simplify builds and actions.

TODO

  1. Adjust server ui and server README as required
  2. Find a way to test the docker cloud build action without pushing potentially broken images
  3. Investigate whether server directory needs to be excluded for npm package
  4. Ensure assets are present for go import of the server module (for cli/temporalite)

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@vercel
Copy link

vercel bot commented Feb 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 14, 2023 at 2:48PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
holocene ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2023 at 2:48PM (UTC)

@cypress
Copy link

cypress bot commented Feb 3, 2023

Passing run #2081 ↗︎

0 89 1 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 2826d50 into 0952c25...
Project: Temporal UI Commit: cd7d182046 ℹ️
Status: Passed Duration: 04:53 💡
Started: Feb 6, 2023 4:22 PM Ended: Feb 6, 2023 4:27 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Keep import path as before.
@feedmeapples feedmeapples self-requested a review February 14, 2023 14:53
@robholland robholland merged commit c6f8417 into main Feb 14, 2023
@robholland robholland deleted the rh-ui-server-merge-2 branch February 14, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants