Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #22: Simplify the expires view #23

Merged
merged 1 commit into from
Mar 24, 2013
Merged

Issue #22: Simplify the expires view #23

merged 1 commit into from
Mar 24, 2013

Conversation

qraynaud
Copy link

Here is the pull request corresponding to the changes discussed in Issue #22. There is no new test or changes in the tests because I didn't moved the API at all. This is only an internal optimization.

… easy view updates. Add update documentation section.
@tdebarochez
Copy link
Owner

Thanks a lot for your pull request, but Travis builds are broken.
Does it works for you ?

@qraynaud
Copy link
Author

Yes, all tests are fine on my side. Looking at the logs, it seems to me there is an issue connecting to Couch (I didn't modified any code related to this). Maybe the couch server the build system is using was down at the time of testing?

@qraynaud
Copy link
Author

Here is the log for the tests using my build :

~/Projects/connect-couchdb$ npm test

> connect-couchdb@0.3.0 test /media/data/Documents/quentin/Projects/connect-couchdb
> NODE_ENV=test expresso test/test.*.js

path.existsSync is now called `fs.existsSync`.

   100% 5 tests

@tdebarochez
Copy link
Owner

Weird... It works here.

tdebarochez added a commit that referenced this pull request Mar 24, 2013
Issue #22: Simplify the expires view
@tdebarochez tdebarochez merged commit 20a024f into tdebarochez:master Mar 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants