fix(gpu): prevent app crash if gpu detect fails #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Misieq01
reviewed
Sep 20, 2024
src-tauri/src/main.rs
Outdated
| @@ -358,7 +358,15 @@ async fn setup_inner( | |||
| .ensure_latest(Binaries::GpuMiner, progress.clone()) | |||
| .await; | |||
|
|
|||
| state.gpu_miner.write().await.detect().await?; | |||
| drop( | |||
There was a problem hiding this comment.
Could you move it outside if statement so its called every time app starts ?
mmrrnn
approved these changes
Sep 23, 2024
stringhandler
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On my integrated intel gpu the gpu miner would fail to detect the gpu causing crash of the entire application. This PR only makes it log error and continue working as gpu mining will be disabled.
Motivation and Context
Stop crashing app with unsupported GPUs.
How Has This Been Tested?
Tested manually on my machine (Ubuntu with integrated intel gpu)
What process can a PR reviewer use to test or verify this change?
same as above
Breaking Changes