Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slack): use conversations api #131

Merged
merged 9 commits into from
Nov 11, 2020
Merged

fix(slack): use conversations api #131

merged 9 commits into from
Nov 11, 2020

Conversation

wass3r
Copy link
Collaborator

@wass3r wass3r commented Mar 6, 2020

❤ THANKS FOR HELPING OUT :D

Proposed change

This addresses and issue with populating channel information reliably. Now uses Conversations API and probably solves #46 (at least in part).

Types of changes

What types of changes is this pull request introducing to flottbot? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

You can fill this out after creating your PR. Put an x in the boxes that apply

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@coveralls
Copy link

coveralls commented Mar 6, 2020

Pull Request Test Coverage Report for Build d1cd816fe34e69a17b583a631a349dc0aaa8235f-PR-131

  • 0 of 45 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 37.578%

Changes Missing Coverage Covered Lines Changed/Added Lines %
remote/slack/helper.go 0 45 0.0%
Files with Coverage Reduction New Missed Lines %
remote/slack/helper.go 2 0%
Totals Coverage Status
Change from base Build 8086b00285376c6f07066ce1aed68aebadc1cdfd: -0.4%
Covered Lines: 838
Relevant Lines: 2230

💛 - Coveralls

@wass3r wass3r marked this pull request as ready for review October 27, 2020 21:46
@wass3r wass3r changed the title fix(slack): use conversations api for channel info fix(slack): use conversations api Oct 28, 2020
@sjqnn
Copy link
Collaborator

sjqnn commented Nov 11, 2020

All of the example rules that I tried appeared to work fine still, DMs work fine, I see the debug messages now coming through for unhandled event types. Anything else you'd like me to try as a test @wass3r ? Otherwise LGTM 👍

@wass3r
Copy link
Collaborator Author

wass3r commented Nov 11, 2020

Excellent, no, I think that's it. Thanks for giving it a whirl.

@wass3r wass3r merged commit 65ce0f3 into master Nov 11, 2020
@wass3r wass3r deleted the fix-channels branch November 11, 2020 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants