Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove lodash, create debounceEvent helper, regex escape #303

Merged

Conversation

jackson-elfers
Copy link
Contributor

@jackson-elfers jackson-elfers commented Mar 16, 2020

Please read the Contribution Guidelines before opening a pull request.

Description

Removes lodash package and replaces with native helpers.
debounce.ts
Escape string for use in Javascript regex

Fixes #272

Browser Checklist

This PR has been tested in the following browsers:

  • Chrome
  • Firefox
  • Safari

@taniarascia taniarascia merged commit 0fc1148 into taniarascia:master Mar 16, 2020
@taniarascia
Copy link
Owner

@all-contributors please add jackson-elfers for code.

@allcontributors
Copy link
Contributor

@taniarascia

I've put up a pull request to add @jackson! 🎉

@taniarascia
Copy link
Owner

@all-contributors please add jackson-elfers for code.

@allcontributors
Copy link
Contributor

@taniarascia

I've put up a pull request to add @jackson! 🎉

@jackson-elfers
Copy link
Contributor Author

jackson-elfers commented Mar 17, 2020

Hey @taniarascia I think your contributor bot got the wrong jackson haha. It's all good. I'll make a pr and do it manually if you don't mind.

@taniarascia
Copy link
Owner

Sorry about that. Apparently the bot didn't recognize what came after the hyphen without a @. Whoops!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor] Remove Lodash and Moment
2 participants