Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: implement error handling in remoteConfigContent function #534

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

tangcent
Copy link
Owner

No description provided.

@tangcent tangcent added the type: bug Something isn't working label Mar 31, 2024
Copy link

codecov bot commented Mar 31, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 62.801%. Comparing base (e881831) to head (e063422).

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##              master      #534       +/-   ##
===============================================
- Coverage     62.802%   62.801%   -0.001%     
  Complexity      1935      1935               
===============================================
  Files            218       218               
  Lines          10420     10425        +5     
  Branches        2538      2539        +1     
===============================================
+ Hits            6544      6547        +3     
- Misses          2529      2531        +2     
  Partials        1347      1347               
Flag Coverage Δ
unittests 62.801% <66.667%> (-0.001%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ugin/settings/helper/RemoteConfigSettingsHelper.kt 69.231% <66.667%> (-1.357%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e881831...e063422. Read the comment docs.

@tangcent tangcent merged commit 38eb9f6 into master Mar 31, 2024
10 checks passed
@tangcent tangcent mentioned this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant