Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backfill the README with instructions and content from the original #45

Merged
merged 3 commits into from
Jun 23, 2023

Conversation

nevinera
Copy link

lemurheavy's coveralls-ruby repository apparently updated its README after this fork, and it has a lot of detail in it that's helpful when trying to get set up. I think it used to rely on the docs being hosted by coverall's site, but that site has since stopped holding them, and now points to your readme, which doesn't include much detail.

For #44

lemurheavy's coveralls-ruby repository apparently updated its README
after this fork, and it has a lot of detail in it that's helpful when
trying to get set up. I think it _used_ to rely on the docs being hosted
by coverall's site, but that site has since stopped holding them, and
now points to _your_ readme, which doesn't include much detail.
@coveralls
Copy link

Coverage Status

coverage: 94.385%. remained the same when pulling 3ebfd4b on nevinera:nev--update-readme-to-match-upstream into 5440895 on tagliala:main.

@tagliala
Copy link
Owner

Hi, thanks for the PR

Running CI was not necessary but I didn't want to ask to add [ci skip] and it is a chance to test against latest ruby-heads

The changelog is quite accurate: https://github.com/tagliala/coveralls-ruby-reborn/blob/main/CHANGELOG.md#changelog

There should be new CIs supported, but I never used those CIs and I can't provide instruction for those

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@tagliala tagliala merged commit 885c270 into tagliala:main Jun 23, 2023
@nevinera
Copy link
Author

Thank-you for your speed, sir! That is by far the fastest anyone has ever responded :-D

@nevinera nevinera deleted the nev--update-readme-to-match-upstream branch June 23, 2023 18:33
@tagliala
Copy link
Owner

Welcome and thanks for having the time to submit a PR. Feel free to make adjustments to the readme if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants