Updates #42
Merged
Updates #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tagliala
commented
Dec 25, 2022
| @@ -65,7 +65,7 @@ def branches(simplecov_branches) | |||
| line_number = branch_data.split(', ')[2].to_i | |||
| data.each_value do |hits| | |||
| branch_number += 1 | |||
| branches_properties.concat([line_number, 0, branch_number, hits]) | |||
| branches_properties.push(line_number, 0, branch_number, hits) | |||
There was a problem hiding this comment.
Ruby version: 3.1.3
Warming up --------------------------------------
concat 415.986k i/100ms
push 529.204k i/100ms
Calculating -------------------------------------
concat 5.427M (± 6.0%) i/s - 27.455M in 5.074033s
push 6.037M (±12.2%) i/s - 30.165M in 5.068373s
Comparison:
push: 6037418.6 i/s
concat: 5426887.3 i/s - same-ish: difference falls within error
Calculating -------------------------------------
concat 240.000 memsize ( 0.000 retained)
2.000 objects ( 0.000 retained)
0.000 strings ( 0.000 retained)
push 200.000 memsize ( 0.000 retained)
1.000 objects ( 0.000 retained)
0.000 strings ( 0.000 retained)
Comparison:
push: 200 allocated
concat: 240 allocated - 1.20x more
Ruby version: 3.2.0
Warming up --------------------------------------
concat 688.921k i/100ms
push 371.644k i/100ms
Calculating -------------------------------------
concat 6.866M (± 1.1%) i/s - 34.446M in 5.017723s
push 6.104M (± 7.5%) i/s - 30.475M in 5.024755s
Comparison:
concat: 6865743.9 i/s
push: 6104350.7 i/s - 1.12x (± 0.00) slower
Calculating -------------------------------------
concat 240.000 memsize ( 0.000 retained)
2.000 objects ( 0.000 retained)
0.000 strings ( 0.000 retained)
push 200.000 memsize ( 0.000 retained)
1.000 objects ( 0.000 retained)
0.000 strings ( 0.000 retained)
Comparison:
push: 200 allocated
concat: 240 allocated - 1.20x more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.