Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configuration for Semaphore CI #34

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Update configuration for Semaphore CI #34

merged 1 commit into from
Mar 11, 2022

Conversation

tagliala
Copy link
Owner

No description provided.

The configuration for Semaphore CI currently relies on two environmental
variables that aren't defined: `ENV['SEMAPHORE_BUILD_NUMBER']` and
`ENV['PULL_REQUEST_NUMBER']`.

The PR uses instead `ENV['SEMAPHORE_WORKFLOW_ID']` as `service_number`
and `ENV['SEMAPHORE_GIT_BRANCH']` as `service_branch`.

Unfortunately, Semaphore CI doesn't provide the reference to the PR in
the environmental variables so `service_pull_request` cannot be set.
@tagliala tagliala marked this pull request as ready for review March 11, 2022 09:08
@tagliala tagliala merged commit 578639f into main Mar 11, 2022
@tagliala tagliala deleted the fix-semaphore branch March 11, 2022 09:09
@tagliala
Copy link
Owner Author

@BastienL thanks

I've preserved your commit so you will be listed as a contributor, but I had to recreate the PR because I wasn't allowed to force push on #32

could you please give a try to the main branch and let me know if it works?

Otherwise, feel free to make a new PR, now CI works

@BastienL
Copy link

@tagliala just gave a try to the main branch and it worked. Thanks for the merge!

@tagliala
Copy link
Owner Author

0.24.0 released
https://github.com/tagliala/coveralls-ruby-reborn/releases/tag/v0.24.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants