-
-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chart.js] add view-value-change event #1605
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smnandre
reviewed
Mar 14, 2024
smnandre
reviewed
Mar 14, 2024
smnandre
reviewed
Mar 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you maybe add a test or two ?
@smnandre test added |
IndraGunawan
changed the title
[Chart.js] introduce on-view-value-changed event
[Chart.js] introduce view-value-change event
Mar 16, 2024
smnandre
reviewed
Mar 17, 2024
smnandre
reviewed
Mar 17, 2024
smnandre
reviewed
Mar 17, 2024
smnandre
reviewed
Mar 17, 2024
IndraGunawan
changed the title
[Chart.js] introduce view-value-change event
[Chart.js] add view-value-change event
Mar 17, 2024
smnandre
approved these changes
Mar 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
carsonbot
added
Status: Reviewed
Has been reviewed by a maintainer
and removed
Status: Needs Review
Needs to be reviewed
labels
Mar 17, 2024
kbond
force-pushed
the
chartjs-introduce-event
branch
from
March 20, 2024 19:15
d5faedb
to
130f7dc
Compare
Thank you @IndraGunawan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was following this tutorial https://ux.symfony.com/demos/live-component/chartjs and everything works fine until I want to modify the
y
axis label.i read about this documentation that I can extend the default behaviour https://symfony.com/bundles/ux-chartjs/current/index.html#extend-the-default-behavior
it works on the initial chart render, but when I change some values the chart gets re-render, and the scale options that I added on
pre-connect
event get overwritten by$chart->setOptions([...])
, when I tried to remove$chart->setOptions([...])
on PHP code completely to use the options fully frompre-connect
, and I got this errorhence I propose to introduce a new event that makes it able to add additional options while we are still using
$chart->setOptions([...])
everytime the chart gets re-renderedthis is also fixed on
viewValueChanged
method if no$chart->setOptions([...])
provided