[Concurrency] Build executors as their own separate object modules. #76483
+1,349
−346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C++ executor implementations were `#include`ed into `GlobalExecutor.cpp`, which makes it difficult to replace the global executor when using the Embedded Concurrency library. Refactor things so that they build into separate objects, which means replacing them is just a matter of writing the relevant functions yourself. rdar://135380149
`ExecutorHooks.h` is now nothing to do with hooks, so rename it. Also there are some additional functions it should declare, and a couple of places where we've slightly messed up the boundary, for instance `swift_task_asyncMainDrainQueue` was defined in `Task.cpp` rather than in the executor implementations, which is wrong, so fix that too. `CooperativeGlobalExecutor.cpp` now builds against the interface from `ExecutorImpl.h`, rather than including the all the concurrency headers. rdar://135380149
When Embedded Concurrency is enabled, install `ExecutorImpl.h` in the `include/swift` directory in the toolchain. rdar://135380149
Added an executor implementation and a test that tries to use it. Also fix up a few issues in `ExecutorImpl.h`. rdar://135380149
al45tair
force-pushed
the
eng/PR-135380149
branch
from
76f9f89
to
7527d31
Compare
|
@swift-ci Please test |
|
Hmmm. Looks like I've broken a few tests there :-) More to do, it seems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to split the global executor implementations out into their own separate object files, because that will allow us to provide a custom executor specific to the target platform when using Embedded Concurrency.
rdar://135380149