Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added full sweep #359

Merged
merged 5 commits into from
Oct 10, 2022
Merged

added full sweep #359

merged 5 commits into from
Oct 10, 2022

Conversation

sarangparikh22
Copy link
Contributor

No description provided.

@matthewlilley
Copy link
Member

@sarangparikh22 LGTM! Can you update the comments in the tests though?

contracts/TridentRouter.sol Outdated Show resolved Hide resolved
@socket-security
Copy link

Socket Security Report

Dependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again.

📜 New install scripts detected

A dependency change in this PR is introducing new install scripts to your install step.

Package Script field Location
web3@1.2.11 (upgraded) postinstall package-lock.json via ethereum-waffle@3.4.0, @ethereum-waffle/provider@3.4.1, ganache-core@2.13.2
Socket.dev scan summary
Issue Status
Did you mean? ✅ no new possible package typos
Install scripts ⚠️ 1 new install script detected
Telemetry ✅ no new telemetry
Troll package ✅ no new troll packages
Malware ✅ no new malware
Native code ✅ no new native modules
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@2.4.2

  • @SocketSecurity ignore web3@1.2.11

⚠️ Please accept the latest app permissions to ensure bot commands work properly. Accept the new permissions here.

Powered by socket.dev

@matthewlilley matthewlilley merged commit 2c5fa7e into master Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants