Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update aal requirements to update user #1766

Merged
merged 7 commits into from
Sep 17, 2024
+78 −0
Merged

fix: update aal requirements to update user #1766

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7c0a128
fix: update aal requirements to update user
J0 Sep 5, 2024
1b25838
fix: udpate session
J0 Sep 5, 2024
72aae98
fix: add test
J0 Sep 6, 2024
00b1d59
fix: refactor into dedicated function
J0 Sep 11, 2024
f489249
fix: update mfa enabled
J0 Sep 11, 2024
7e897c6
fix: update HasMFAEnabled
J0 Sep 11, 2024
fb5b009
fix: add parens, add phone as sensitive field
J0 Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: add parens, add phone as sensitive field
  • Loading branch information
@J0
J0 committed Sep 11, 2024
commit fb5b00940f44b34bc0e305c83d1a547f02202daa
2 changes: 1 addition & 1 deletion internal/api/user.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ func (a *API) UserUpdate(w http.ResponseWriter, r *http.Request) error {
}

if user.HasMFAEnabled() && !session.IsAAL2() {
if (params.Password != nil && *params.Password != "") || params.Email != "" && user.GetEmail() != params.Email {
if (params.Password != nil && *params.Password != "") || (params.Email != "" && user.GetEmail() != params.Email) || (params.Phone != "" && user.GetPhone() != params.Phone) {
return httpError(http.StatusUnauthorized, ErrorCodeInsufficientAAL, "AAL2 session is required to update email or password when MFA is enabled.")
}
}
Expand Down
Loading