-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update aal requirements to update user #1766
Conversation
Pull Request Test Coverage Report for Build 10812950524Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Co-authored-by: Stojan Dimitrovski <sdimitrovski@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code wise I see no issues long as the logic behind the added checks is sound.
What kind of change does this PR introduce?
If a user has verified factors (mfa enabled) we should require an AAL2 session in order to proceed with any operation
We restrict phone, email, and password from updates as we consider those as sensitive fields
Context: https://supabase.slack.com/archives/C02AK9166FR/p1725466764804889