Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: pre-commit updates #542

Merged
merged 3 commits into from
Aug 16, 2023
Merged

ci: pre-commit updates #542

merged 3 commits into from
Aug 16, 2023

Conversation

vbarua
Copy link
Member

@vbarua vbarua commented Aug 16, 2023

  • use flake8 from github
  • update pre-commit hooks

@vbarua
Copy link
Member Author

vbarua commented Aug 16, 2023

Pulling the flake8 pre-commit hook from gitlab means that users need to authenticate with gitlab when installing it:

➜  substrait git:(main) pre-commit run
[INFO] Initializing environment for https://gitlab.com/pycqa/flake8.
Username for 'https://gitlab.com': 

If we pull it from github, there's no need for authentication

➜  substrait git:(vbarua/pre-commit-updates) ✗ git commit -am "chore: pre-commit autoupdate"
[INFO] Installing environment for https://github.com/psf/black.

While I was touching the pre-commit hooks I updated them and ran them over the whole repo.

@vbarua vbarua marked this pull request as ready for review August 16, 2023 18:38
@vbarua
Copy link
Member Author

vbarua commented Aug 16, 2023

These changes only affects CI and as such can be merged with only commiter approval. Thanks David!

@vbarua vbarua merged commit 9078041 into main Aug 16, 2023
15 checks passed
@vbarua vbarua deleted the vbarua/pre-commit-updates branch August 16, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants