Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support of license types in Nuget test artifacts #1966

Merged
merged 3 commits into from
Dec 10, 2020

Conversation

anki2189
Copy link
Member

@anki2189 anki2189 commented Dec 1, 2020

Pull Request Description

This pull request closes #1726

Acceptance Test

  • Building the code with mvn clean install -Dintegration.tests still works.
  • Running mvn spring-boot:run in the strongbox-web-core still starts up the application correctly.
  • Building the code and running the strongbox-distribution from a zip or tar.gz still works.
  • The tests in the strongbox-web-integration-tests still run properly.

Questions

  • Does this pull request break backward compatibility?

    • Yes
    • No
  • Does this pull request require other pull requests to be merged first?

  • Does this require an update of the documentation?

    • Yes, please see strongbox/strongbox-docs#{PR_NUMBER}
    • No

Code Review And Pre-Merge Checklist

  • My code follows the coding convention of this project.
  • I have performed a self-review of my own code.
  • I have commented my code in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@carlspring
Copy link
Member

Hi @anki2189 ,

Thanks for this pull request!

Could you please:

  • Rebase this pull request
  • Add a link to the documentation of NPM where this is specified
  • Add some sample output of what is currently being generated from the tests

Much appreciated!

@carlspring
Copy link
Member

@anki2189 ,

What is the status of this pull request? Is it ready for review?

Could you please rebase it? Thanks! :)

@anki2189
Copy link
Member Author

anki2189 commented Dec 9, 2020

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<package xmlns="http://schemas.microsoft.com/packaging/2011/08/nuspec.xsd">
    <metadata>
        <id>nuget-artifact-without-license</id>
        <version>1.0.0</version>
        <authors>carlspring</authors>
        <owners>Carlspring Consulting &amp;amp; Development Ltd.</owners>
        <description>Strongbox Nuget package for tests</description>
        <dependencies/>
    </metadata>
</package>
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<package xmlns="http://schemas.microsoft.com/packaging/2011/08/nuspec.xsd">
    <metadata>
        <id>nuget-artifact-with-license</id>
        <version>1.0.0</version>
        <authors>carlspring</authors>
        <owners>Carlspring Consulting &amp;amp; Development Ltd.</owners>
        <licenseUrl>https://opensource.org/licenses/MIT</licenseUrl>
        <description>Strongbox Nuget package for tests</description>
        <dependencies/>
    </metadata>
</package>

@anki2189
Copy link
Member Author

anki2189 commented Dec 9, 2020

@anki2189 ,

What is the status of this pull request? Is it ready for review?

Could you please rebase it? Thanks! :)

Yes, it is ready for review.

@carlspring
Copy link
Member

@anki2189 ,

Thanks for the example output! Could you please also add a link to the NuGet documentation where this is described? Thanks! :)

@carlspring carlspring merged commit 8aecf0d into strongbox:master Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it possible to specify the license types of Nuget test artifacts
2 participants