Attempt to remove some e2e flakiness #9423
Conversation
lukasmasuch
changed the title
There was a problem hiding this comment.
LGTM, thank you! Could you please update the PR description with an information why the cat image was replaced. Based on our conversation it has something to do with the fact that sometimes the images are shown in a lower resolution in the beginning, probably due to some browser-behavior. It'd be great to capture this in the PR for future reference.
| LOREM_IPSUM = "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua." | ||
|
|
||
| BLACK_IMG = np.repeat(0, 601350).reshape(633, 950) |
There was a problem hiding this comment.
Replaced the cat image with a black image since it seems that it sometimes leads to a non-sharp version of the image being screenshotted -> which likely is a result of some browser optimization that first shows a less detailed version of the image. Since the test is about columns and not our image rendering, I just replaced it with a black image to not run into this issue.
Describe your changes
This PR attempts to reduce some e2e test flakiness based on this list.
Replaced the cat image with a black image since it seems that it sometimes leads to a non-sharp version of the image being screenshotted -> which likely results from some browser optimization that first shows a less detailed version of the image. Since the test is about columns and not our image rendering, I just replaced it with a black image to avoid this issue.
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.