Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on FreeBSD (and unix) #32

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Conversation

lbartoletti
Copy link
Contributor

Hi,

Thanks for this project!

I propose a PR to build jupyternim on FreeBSD (and other unix like), since the traditional path is the same on linux and other unix.

@stisa
Copy link
Owner

stisa commented Dec 17, 2021

Hi! Thanks for the PR. Looks good to me.
Do you know where I could find a list of defines? I found https://github.com/nim-lang/Nim/wiki/Consts-defined-by-the-compiler but unix isn't on it. I know it works and I've seen it in the stdlib code, but I can't find where it gets set, it's been a while since I read the compiler code

@lbartoletti
Copy link
Contributor Author

I guess here

@stisa stisa merged commit 84edc11 into stisa:master Dec 20, 2021
@lbartoletti lbartoletti deleted the fix_build_unix branch December 20, 2021 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants