Use error for invalid DisplayKind in show
#28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ire4ever1190
commented
Oct 7, 2021
src/jupyternimpkg/display.nim
Outdated
| @@ -105,7 +106,7 @@ template show*(kind:DisplayKind, what:untyped) = | |||
| elif kind == dkPlot: | |||
| content = showBase64StringPng(what, size[0], size[1]) | |||
There was a problem hiding this comment.
@stisa I also noticed this line which will throw error if size is not defined in scope. Should this be removed or left in?
There was a problem hiding this comment.
yep looks like I forgot to remove that branch, it should be caught by the other show template, thanks for noticing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using dkHtml in
showgave thiswhich while says the issue, also gives a nil access error that I found to be confusing. This PR uses the
{.error.}pragma insteadso that a compile time error is thrown instead