Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: cleanup didn't unswizzle classes that had already been swizzled #40

Merged
merged 1 commit into from
Apr 1, 2015
Merged

Bugfix: cleanup didn't unswizzle classes that had already been swizzled #40

merged 1 commit into from
Apr 1, 2015

Commits on Mar 31, 2015

  1. Bugfix: cleanup didn't unswizzle classes that had already been swizzled 

    This would happen when using other code that itself swizzles classes (i.e. ReactiveCocoa). For example, if a rac_signalForSelector was called on an object then later an aspect hook was installed and further removed, we would end up in a situation where Aspect's class swizzling (in-place swizzling of -forwardInvocation:) would never be ununstalled when the last hook was removed, later wrecking havoc with RAC's own use of -forwardInvocation.

In short, this pull request fixes hair-pulling crashes.
    @fpillet
    fpillet committed Mar 31, 2015
    Configuration menu
    Copy the full SHA
    7d2cdf5 View commit details
    Browse the repository at this point in the history