[5.x] Allow make:addon to work for any minimum-stability #10814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ideally we should avoid that. If you don't have It's just a matter of figuring out what branch it needs. |
|
Going to mark this as a draft for now, until I have time to dig into this some more. |
|
I think this does it. Wanna check? |
|
Yep, that does it! Thanks for taking a look. |
jasonvarga
changed the title
minimum-stability is dev before requiring new addon
jasonvarga
deleted the
ensure-minimum-stability-is-set-before-requiring-dev-dependency
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue with the
php please make:addoncommand where Composer will throw an error when requiring a new addon when an app'sminimum-stabilitysetting is anything other thandev.