Full test coverage #178
Open
Full test coverage #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR
contracts/VerifyingPaymaster.sol.Coverage
Extended the hardhat tests to increase code coverage to 100% for all metrics.
Before
After
Unnecessary Require Branch in VerifyingPaymaster.sol
As the increased test coverage to
should revert on invalid signaturetest reveals, even if a signature with length 64 is passed to thesimulateValidationfunction on theentryPointcontract, and subsequently passes the require check on line 96, the call will still revert due to the OpenZeppelin ECDSA library requiring that the signature length be equal to 65. Thus, the branch in this require check can be removed, as it is superfluous.No changes to the
contracts/VerifyingPaymaster.solcontract has been made due to extant live deployments of this contract, and the desire to maintain consistency between this repo and the canonical contracts.