Add support for X1-Smart #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Epic work mate! Glad our workaround for direct access worked also! It has been flawless for us. |
|
Hey mate, thanks for taking the time to open a PR. I’ll do my best to have this reviewed and merged soon |
|
I might just have a small re-factor after we add this, but I can merge as-is and then do the fix after. |
…s/JMacalinao/master # Conflicts: # solax/inverter.py # tests/fixtures.py
|
@JMacalinao let me know what you think. I did add some unrelated changes though to make the linter happier |
|
LGTM 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! First time contributing to this project; let me know if there's other stuff I need to add.
Added support for the X1-Smart inverter, tested using my own system so I can integrate it into Home Assistant.
Also added a make_request method for the inverter with the X-Forwarded-For workaround from #47 so I can access the API directly via LAN. (I had to downgrade the Pocket WiFi firmware to v2.033.20 as mentioned there to get it to work.)