Allow client to inject own Mustache.Compiler #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 10, 2014 17:29
…cted so the client can have full control over it. For backwards compatibility, the setter is optional.
sps
added a commit
that referenced
this pull request
Feb 12, 2014
Allow client to inject own Mustache.Compiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've removed the injection of nullValue and emptyStringIsFalse properties into MustacheViewResolver and, instead, replaced them with the ability for the client to optionally inject a pre-customized compiler. This commit is still backwards compatible with versions 1.1.1 and prior since the Compiler injection is optional. There is an incompatibility with 1.1.2 since the nullValue and emptyStringIsFalse properties have been removed.
This gives the client the flexibility to try different Compiler configurations within their own code base. Also, this prevents this library from having to be updated every time a new Compiler property is added/removed from the Mustache library.