Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header definitions are overriding others #893

Closed
hirth-abi opened this issue Aug 2, 2024 · 4 comments
Closed

Header definitions are overriding others #893

hirth-abi opened this issue Aug 2, 2024 · 4 comments
Labels
bug Something isn't working staged for release

Comments

@hirth-abi
Copy link

Describe the bug

When multiple @AsyncOperations with @Headers are defined, only one of them will be used for all.

Se my reproducer project where different header values should be shown:

SCR-20240802-jif

Additionally in the old UI a strange schema with "undefined-title" is shown for it:

SCR-20240802-jje

Dependencies and versions used

Tested in 1.5.0

Code example

master...hirth-abi:springwolf-core:header-override

Stack trace and error logs

@timonback
Copy link
Member

timonback commented Aug 3, 2024

Hi @hirth-abi,
have you tried adding the schemaName in AsyncOperation.Headers?
(Validation for the field is added in #896 )

The alternative would be to auto-generated a schemaName, like <channelName>-<hash-of-headers>. Do you have thoughts on this?

@timonback timonback added the waiting for feedback Waiting for user feedback/response label Aug 4, 2024
@hirth-abi
Copy link
Author

hirth-abi commented Aug 5, 2024

Yes, that works if the schema is different and defining the schema name in a meaningful non-generated way seems to be better 👍 (it just looks a bit strange - although technically correct - to have a different header schema per message, just because the same standardized header is sent with a different value)

@github-actions github-actions bot removed the waiting for feedback Waiting for user feedback/response label Aug 5, 2024
sam0r040 added a commit to sam0r040/springwolf-core that referenced this issue Aug 23, 2024
…ringwolfGH-893

Co-authored-by: Timon Back <timonback@users.noreply.github.com>
sam0r040 added a commit to sam0r040/springwolf-core that referenced this issue Aug 23, 2024
…ringwolfGH-893

Co-authored-by: Timon Back <timonback@users.noreply.github.com>
Copy link

The change is staged for release and will be part of the next release.

If you want to try and verify it in your application today,
use the latest 1.X.0-SNAPSHOT build as described in our README.md > Testing SNAPSHOT version

Thank you for the report/contribution!

timonback added a commit that referenced this issue Aug 23, 2024
…-893 (#940)

Co-authored-by: Timon Back <timonback@users.noreply.github.com>
Copy link

The change is available in the latest release. 🎉

Thank you for the report/contribution and making Springwolf better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working staged for release
Projects
None yet
Development

No branches or pull requests

2 participants