-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ObservationRegistry is never post-processed #15658
Comments
I suspect this commit is the problem: In particular, (This bit is certainly different in 6.3.1) Logs indicate:
Creating |
@mmoayyed, thanks for the timely and detailed report. I've pushed a change that I believe repairs the issue. It will be available as Also, I've added spring-projects/spring-security-samples#313 to improve our testing around Security together with |
Thank you very much for the fix. I can confirm the issue is no longer there; all startup warnings are gone and I can correctly see the appropriate metrics. Cheers! |
By the way, I see that 6.3.3 is scheduled to be released on Oct 21st. That seems a little too far, wouldn't you agree, given the severity level of this bug? Do you think it makes sense to move up the release schedule to get this bug fix out? (I can of course stay on 6.3.1 for the time being, so not a blocker really). |
Yes, @mmoayyed, the release is being moved up to today, I just hadn't updated the milestone date; I've done that now. |
Thank you so much! |
Describe the bug
I am running a Spring Boot web application with JDK 21 with the following versions/components:
This application is tasked to simply review metrics produced by the
metrics
endpoint. With the above components, I begin to see warnings like this:Furthermore, the observation registry created by Spring Boot,
...is never post-processed via
ObservationRegistryPostProcessor
, and as a result quite a number of metrics end up missing, particularly those that deal withhttp.server.requests
and family.Why Spring Security?
If I keep everything EXACTLY THE SAME and only go back to
springSecurityVersion=6.3.1
,I am not seeing anything relevant from the commit log, but I could be missing something. Again, the only thing that I do change from run to run is the Spring Security version; everything else is exactly the same as before.
Expected behavior
Http exchanges should be collected and exported as metrics.
Sample
I am working on a sample that would hopefully produce this but this might do, although I have to apologize as it's not really a lightweight thing:
The application settings that control default SSL settings, etc with Spring Boot are defined in:
If I can help further, please let me know.
The text was updated successfully, but these errors were encountered: