Improve Java DSL for Rabbit Streams #8598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Expose simple properties for `streamName` and `superStream` on the `RabbitStreamInboundChannelAdapterSpec` * Add `superStream(String superStream, String name, int consumers)` option * Add `outboundStreamAdapter(Environment environment, String streamName)` factory for simple use-cases * Add `RabbitStreamTests` integration test to cover Rabbit Streams support and demonstrate respective Java DSL * Mention the change in the docs
artembilan
force-pushed
the
Improve_RabbitStream_DSL
branch
from
ed23236
to
646213b
Compare
garyrussell
suggested changes
Apr 17, 2023
src/reference/asciidoc/amqp.adoc
Outdated
| @@ -1426,7 +1426,7 @@ image::images/spring-integration-amqp-sample-graph.png[align="center"] | |||
|
|
|||
| Version 6.0 introduced support for RabbitMQ Stream Queues. | |||
|
|
|||
| The DSL factory class for these endpoints is `Rabbit`. | |||
| The DSL factory class for these endpoints is a `RabbitStream`. | |||
There was a problem hiding this comment.
Suggested change
| The DSL factory class for these endpoints is a `RabbitStream`. | |
| The DSL factory class for these endpoints is `RabbitStream`. |
Comment on lines
58
to
77
| /** | ||
| * Configure a name for Rabbit super stream to consume from. | ||
| * @param superStream the name of Rabbit super stream. | ||
| * @param consumerName the logical name to enable offset tracking. | ||
| * @return the spec | ||
| * @since 6.1 | ||
| */ | ||
| public RabbitStreamInboundChannelAdapterSpec superName(String superStream, String consumerName) { | ||
| return superName(superStream, consumerName, 1); | ||
| } | ||
|
|
||
| /** | ||
| * Configure a name for Rabbit super stream to consume from. | ||
| * @param superStream the name of Rabbit super stream. | ||
| * @param consumerName the logical name to enable offset tracking. | ||
| * @param consumers the number of consumers. | ||
| * @return the spec | ||
| * @since 6.1 | ||
| */ | ||
| public RabbitStreamInboundChannelAdapterSpec superName(String superStream, String consumerName, int consumers) { |
There was a problem hiding this comment.
The docs say this is superStream (which I think is better).
Suggested change
| /** | |
| * Configure a name for Rabbit super stream to consume from. | |
| * @param superStream the name of Rabbit super stream. | |
| * @param consumerName the logical name to enable offset tracking. | |
| * @return the spec | |
| * @since 6.1 | |
| */ | |
| public RabbitStreamInboundChannelAdapterSpec superName(String superStream, String consumerName) { | |
| return superName(superStream, consumerName, 1); | |
| } | |
| /** | |
| * Configure a name for Rabbit super stream to consume from. | |
| * @param superStream the name of Rabbit super stream. | |
| * @param consumerName the logical name to enable offset tracking. | |
| * @param consumers the number of consumers. | |
| * @return the spec | |
| * @since 6.1 | |
| */ | |
| public RabbitStreamInboundChannelAdapterSpec superName(String superStream, String consumerName, int consumers) { | |
| /** | |
| * Configure a name for Rabbit super stream to consume from. | |
| * @param superStream the name of Rabbit super stream. | |
| * @param consumerName the logical name to enable offset tracking. | |
| * @return the spec | |
| * @since 6.1 | |
| */ | |
| public RabbitStreamInboundChannelAdapterSpec superStream(String superStream, String consumerName) { | |
| return superStream(superStream, consumerName, 1); | |
| } | |
| /** | |
| * Configure a name for Rabbit super stream to consume from. | |
| * @param superStream the name of Rabbit super stream. | |
| * @param consumerName the logical name to enable offset tracking. | |
| * @param consumers the number of consumers. | |
| * @return the spec | |
| * @since 6.1 | |
| */ | |
| public RabbitStreamInboundChannelAdapterSpec superStream(String superStream, String consumerName, int consumers) { |
| IntegrationFlow superStreamConsumer(Environment env) { | ||
| return IntegrationFlow.from( | ||
| RabbitStream.inboundAdapter(env) | ||
| .superName("test.superStream1", "mySuperConsumer")) |
There was a problem hiding this comment.
Suggested change
| .superName("test.superStream1", "mySuperConsumer")) | |
| .superStream("test.superStream1", "mySuperConsumer")) |
garyrussell
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
streamNameandsuperStreamon theRabbitStreamInboundChannelAdapterSpecsuperStream(String superStream, String name, int consumers)optionoutboundStreamAdapter(Environment environment, String streamName)factory for simple use-casesRabbitStreamTestsintegration test to cover Rabbit Streams support and demonstrate respective Java DSL