Skip to content

Commit

Permalink
dotgit: add test for bad file in pack directory
Browse files Browse the repository at this point in the history
Suggested by mcuadros.

Issue: src-d#807
Signed-off-by: Jeremy Stribling <strib@alum.mit.edu>
  • Loading branch information
strib committed Apr 16, 2018
1 parent 6ea6016 commit 79db8cf
Showing 1 changed file with 13 additions and 1 deletion.
14 changes: 13 additions & 1 deletion storage/filesystem/internal/dotgit/dotgit_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ func findReference(refs []*plumbing.Reference, name string) *plumbing.Reference
return nil
}

func (s *SuiteDotGit) TestObjectsPack(c *C) {
func (s *SuiteDotGit) TestObjectPacks(c *C) {
f := fixtures.Basic().ByTag(".git").One()
fs := f.DotGit()
dir := New(fs)
Expand All @@ -427,6 +427,18 @@ func (s *SuiteDotGit) TestObjectsPack(c *C) {
c.Assert(err, IsNil)
c.Assert(hashes, HasLen, 1)
c.Assert(hashes[0], Equals, f.PackfileHash)

// Make sure that a random file in the pack directory doesn't
// break everything.
badFile, err := fs.Create("objects/pack/OOPS_THIS_IS_NOT_RIGHT.pack")
c.Assert(err, IsNil)
err = badFile.Close()
c.Assert(err, IsNil)

hashes2, err := dir.ObjectPacks()
c.Assert(err, IsNil)
c.Assert(hashes2, HasLen, 1)
c.Assert(hashes[0], Equals, hashes2[0])
}

func (s *SuiteDotGit) TestObjectPack(c *C) {
Expand Down

0 comments on commit 79db8cf

Please sign in to comment.