feat: custom assigning workflow #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afonsojramos
force-pushed
the
feat/update-assign-on-theme-workflow
branch
from
4f62441
to
361283c
Compare
afonsojramos
requested review from
rxri,
harbassan,
theRealPadster and
3raxton
theRealPadster
approved these changes
Dec 19, 2023
|
My only note would be that we might get false positives for the "Default" one, but that's kind of unavoidable. |
@theRealPadster Well, yeah 😥 But that was already expected. We can always remove that entry if we feel like it is affecting it too much, but for now I tried to maintain functionality. |
afonsojramos
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current action is now deprecated as it is using
node12, so replacing with our own should improve these matters and our control over the workflow.Okay, it is now fully working I believe 👌