Fix IKOS tutorial (#138). #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that space_nav2 fails also on main, so it is unrelated to this PR |
xfiderek
force-pushed
the
ikos
branch
2 times, most recently
from
ce68ece
to
0044989
Compare
|
I'm looking into this. |
|
@ivanperez-keera failure of space_robots CI is unrelated to this PR |
|
Thanks, @xfiderek . |
ivanperez-keera
approved these changes
Apr 25, 2024
|
@xfiderek I made a minor change to the commit messages prior to the merge. Just waiting on the build but it should all be fine. |
Add environment variable to entrypoint of spaceros image. This variable is required for ikos-scan to execute and generate .ikosbin files without having to run the ikos-scan server.
The current instructions specify how to re-run all tests, which takes substantial time. This change explains how to run ikos-scan specifically, which should be faster than running all tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #138, by adjusting the Earthfile, entrypoint.sh, and README.md, so that IKOS tutorial is runnable.