parse binds to match docker cli parsing of -v #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
someara
pushed a commit
that referenced
this pull request
Jan 3, 2016
parse binds to match docker cli parsing of -v
|
I merged this thinking I could flip the logic around quickly to make volumes the canonical property. Will take another crack at it tomorrow |
|
Hah yea it wasn't so easy. I think it is mainly done in my branch that I haven't pushed up yet. I don't get back from Philippines until Jan 10th though. |
|
No problem! I'm going to be in Seattle next week, so I'm going to be a little -s On Sun, Jan 3, 2016 at 2:42 AM, Chase Bolt notifications@github.com wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with great pleasure i bring you this fantastic, over the top, (some say) majestic, PR that resolves #493