consolidate sign-in forms and use standard tailwind styles #5746
+345
−450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Consolidates the sign-in forms (previously there was a misnomer OnboardingExperiment and then a ClientSignInForm in 2 separate files) - Uses Tailwind styles instead of the old-style and more verbose CSS - Updates the storybook No behavior change, slight look-and-feel change but no change in wording or layout.
sqs
force-pushed
the
sqs/sign-in-form
branch
from
542b555
to
e0d2c39
Compare
|
@abeatrix , @olafurpg does VS/Eclipse use this alternative login form? AFAIK it currently does not work in JetBrains and is only displayed in error, although @pkukielka is working on fixing one of them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<input type="url">meant it failed at an even earlier stage)No behavior change, slight look-and-feel change but no change in wording or layout.
VS Code
JetBrains
Test plan
Try signing in using VS Code.