pass chat history to webview using webviewAPI, not old postMessage protocol #5741
+205
−147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sqs
force-pushed
the
sqs/history-api
branch
from
863a054
to
6228701
Compare
vovakulikov
reviewed
Sep 29, 2024
There was a problem hiding this comment.
Tested manually in Cody Web demo and linked in Sourcegraph Web
Found a few problems (nothing big but just UI/UX regressions)
- It looks like there is no way to reach zero empty state that we've added here Add zero state for history tab #5390 anymore
- Chat deleting doesn't work right if we try to delete the chat that we're currently in. Not sure this is a PR problem, the real issue here is how we work with active panel IDs (once we delete chat we delete the panel id but without the panel id we can't send anything through the postMessage channel, feel free to ignore it)
sqs
force-pushed
the
sqs/history-api
branch
3 times, most recently
from
80099b0
to
10205fc
Compare
|
@vovakulikov Cool, I fixed the empty state problem and added a test to verify the fix (after confirming it manually). |
sqs
force-pushed
the
sqs/history-api
branch
from
10205fc
to
53869de
Compare
|
Stamp because @vovakulikov reviewed it and I fixed the one outstanding issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, chat history was synced to the webview using the old postMessage protocol. Now, the ChatHistoryManager exposes an observable and that is read directly (using the standard webviewAPI) by the webview. This is a code refactor with no user-facing behavior change.
Test plan
In Cody Web and in VS Code, try downloading chat history. Ensure the JSON file is downloaded and is a JSON array of chat history.